diff options
| author | Philip <pipcet@gmail.com> | 2015-04-28 09:23:29 +0000 |
|---|---|---|
| committer | Philip <pipcet@gmail.com> | 2015-04-28 09:23:29 +0000 |
| commit | 44c330d647c3e1a17e7169f5aa5abb322166fdae (patch) | |
| tree | 156d320df5b092f03fb22035722eca749cb31f68 /tests/tests2 | |
| parent | d2dd6fdbfb491c87138eb8d7590fbb28f471ec8d (diff) | |
| download | tinycc-44c330d647c3e1a17e7169f5aa5abb322166fdae.tar.gz tinycc-44c330d647c3e1a17e7169f5aa5abb322166fdae.tar.bz2 | |
VLA fix: save stack pointer right after modification
This patch disables the optimization of saving stack pointers lazily,
which didn't fully take into account that control flow might not reach
the stack-saving instructions. I've decided to leave in the extra calls
to vla_sp_save() in case anyone wants to restore this optimization.
Tests added and enabled.
There are two remaining bugs: VLA variables can be modified, and jumping
into the scope of a declared VLA will cause a segfault rather than a
compiler error. Both of these do not affect correct C code, but should
be fixed at some point. Once VLA variables have been made properly
immutable, we can share them with the saved stack pointer and save stack
and instructions.
Diffstat (limited to 'tests/tests2')
| -rw-r--r-- | tests/tests2/79_vla_continue.c | 24 | ||||
| -rw-r--r-- | tests/tests2/79_vla_continue.expect | 1 | ||||
| -rw-r--r-- | tests/tests2/Makefile | 6 |
3 files changed, 28 insertions, 3 deletions
diff --git a/tests/tests2/79_vla_continue.c b/tests/tests2/79_vla_continue.c index 9c48c1d..19301e0 100644 --- a/tests/tests2/79_vla_continue.c +++ b/tests/tests2/79_vla_continue.c @@ -81,12 +81,36 @@ void test4() } } +void test5() +{ + int count = 10; + int a[f()]; + int c[f()]; + + c[0] = 42; + + for(;count--;) { + int b[f()]; + int i; + for (i=0; i<f(); i++) { + b[i] = count; + } + } + + if (c[0] == 42) { + printf("OK\n"); + } else { + printf("NOT OK\n"); + } +} + int main(void) { test1(); test2(); test3(); test4(); + test5(); return 0; } diff --git a/tests/tests2/79_vla_continue.expect b/tests/tests2/79_vla_continue.expect index b462a5a..21da4d2 100644 --- a/tests/tests2/79_vla_continue.expect +++ b/tests/tests2/79_vla_continue.expect @@ -2,3 +2,4 @@ OK OK OK OK +OK diff --git a/tests/tests2/Makefile b/tests/tests2/Makefile index 6148c0b..a441674 100644 --- a/tests/tests2/Makefile +++ b/tests/tests2/Makefile @@ -96,9 +96,9 @@ TESTS = \ 74_nocode_wanted.test \ 75_array_in_struct_init.test \ 76_dollars_in_identifiers.test \ - 77_push_pop_macro.test -# 78_vla_label.test -- currently broken -# 79_vla_continue.test -- currently broken + 77_push_pop_macro.test \ + 78_vla_label.test \ + 79_vla_continue.test # 34_array_assignment.test -- array assignment is not in C standard |