diff options
| author | Michael Matz <matz@suse.de> | 2016-08-15 05:09:31 +0200 |
|---|---|---|
| committer | Michael Matz <matz@suse.de> | 2016-12-15 17:47:10 +0100 |
| commit | be6d8ffc107db78d0542b5ee2d3306e7e132725c (patch) | |
| tree | fd76a1e61b710ed0cec5b5d800a3be4868be9b72 /libtcc.c | |
| parent | d0d25ec7df636deaf650d31ae3b50e60659f54dd (diff) | |
| download | tinycc-be6d8ffc107db78d0542b5ee2d3306e7e132725c.tar.gz tinycc-be6d8ffc107db78d0542b5ee2d3306e7e132725c.tar.bz2 | |
Fix access-after-free with statement expressions
The return value of statement expressions might refer to local
symbols, so those can't be popped. The old error message always
was just a band-aid, and since disabling it for pointer types it
wasn't effective anyway. It also never considered that also the
vtop->sym member might have referred to such symbols (see the
testcase with the local static, that used to segfault).
For fixing this (can be seen better with valgrind and SYM_DEBUG)
simply leave local symbols of stmt exprs on the stack.
Diffstat (limited to 'libtcc.c')
| -rw-r--r-- | libtcc.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -677,8 +677,8 @@ static int tcc_compile(TCCState *s1) s1->error_set_jmp_enabled = 0; free_inline_functions(s1); - sym_pop(&global_stack, NULL); - sym_pop(&local_stack, NULL); + sym_pop(&global_stack, NULL, 0); + sym_pop(&local_stack, NULL, 0); return s1->nb_errors != 0 ? -1 : 0; } |
