From 64b5ee2dea3a50ef52f9849364b7b1d6e94bf62d Mon Sep 17 00:00:00 2001 From: Thomas Preud'homme Date: Sat, 12 Nov 2016 23:16:04 +0800 Subject: Rename add_elf_sym to set_elf_sym add_elf_sym is a confusing name because it is not clear what the function does compared to put_elf_sym. As a matter of fact, put_elf_sym also adds a symbol in a symbol table. Besides, "add_elf_sym" fails to convey that the function can be used to update a symbol (for instance its value). "set_elf_sym" seems like a more appropriate name: it will set a symbol to a given set of properties (value, size, etc.) and create a new one if non exist for that name as one would expect. --- tccgen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tccgen.c') diff --git a/tccgen.c b/tccgen.c index d064024..b056c1e 100644 --- a/tccgen.c +++ b/tccgen.c @@ -300,7 +300,7 @@ ST_FUNC void put_extern_sym2(Sym *sym, Section *section, name = get_tok_str(sym->asm_label, NULL); } info = ELFW(ST_INFO)(sym_bind, sym_type); - sym->c = add_elf_sym(symtab_section, value, size, info, other, sh_num, name); + sym->c = set_elf_sym(symtab_section, value, size, info, other, sh_num, name); } else { esym = &((ElfW(Sym) *)symtab_section->data)[sym->c]; esym->st_value = value; -- cgit v1.3.1