From cc6cb7f0e294f0c98c4970c7ec993709fc2daa1a Mon Sep 17 00:00:00 2001 From: Michael Matz Date: Mon, 4 Dec 2017 03:51:14 +0100 Subject: Fix another corner case with C/asm symtable See testcase (from grischka). If the asm has no .globl, but there's a (non-static) C definition the symbol should be exported, even if the first reference comes from asm. --- tccasm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'tccasm.c') diff --git a/tccasm.c b/tccasm.c index ba76c17..15f1e43 100644 --- a/tccasm.c +++ b/tccasm.c @@ -422,9 +422,10 @@ ST_FUNC void asm_free_labels(TCCState *st) for(s = st->asm_labels; s != NULL; s = s1) { ElfSym *esym = elfsym(s); s1 = s->prev; - /* Possibly update binding and visibility from asm directives. */ + /* Possibly update binding and visibility from asm directives + if the symbol has no C decl (type is VT_VOID).*/ s->type.t &= ~VT_EXTERN; - if (esym) { + if (esym && s->type.t == VT_VOID) { if (!s->a.asmexport && esym->st_shndx != SHN_UNDEF) s->type.t |= VT_STATIC; if (s->a.visibility) -- cgit v1.3.1