From b691585785086024549cfb9ac65f3397263965aa Mon Sep 17 00:00:00 2001 From: grischka Date: Tue, 4 Oct 2016 17:36:51 +0200 Subject: tccgen: arm/i386: save_reg_upstack tccgen.c:gv() when loading long long from lvalue, before was saving all registers which caused problems in the arm function call register parameter preparation, as with void foo(long long y, int x); int main(void) { unsigned int *xx[1], x; unsigned long long *yy[1], y; foo(**yy, **xx); return 0; } Now only the modified register is saved if necessary, as in this case where it is used to store the result of the post-inc: long long *p, v, **pp; v = 1; p = &v; p[0]++; printf("another long long spill test : %lld\n", *p); i386-gen.c : - found a similar problem with TOK_UMULL caused by the vstack juggle in tccgen:gen_opl() (bug seen only when using EBX as 4th register) --- arm-gen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'arm-gen.c') diff --git a/arm-gen.c b/arm-gen.c index cca9da5..9b6bca2 100644 --- a/arm-gen.c +++ b/arm-gen.c @@ -1177,7 +1177,8 @@ again: } } - /* second pass to restore registers that were saved on stack by accident */ + /* second pass to restore registers that were saved on stack by accident. + Maybe redundant after the "lvalue_save" patch in tccgen.c:gv() */ if (++pass < 2) goto again; -- cgit v1.3.1